submit_bh/submit_bh_wbc are non-blocking functions which just submits the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait on buffer till I/O completion and then check buffer head's b_state field to know if there was any I/O error. Hence there is no need for these functions to have any return type. Even now they always returns 0. Hence drop the return value and make their return type as void to avoid any confusion. RFC -> PATCHv2 =============== 1. Added Patch-2 to fix ntfs_submit_bh_for_read() caller. 2. Added Reviewed-by from Christoph. Ritesh Harjani (4): jbd2: Drop useless return value of submit_bh fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read fs/buffer: Drop useless return value of submit_bh fs/buffer: Make submit_bh & submit_bh_wbc return type as void fs/buffer.c | 19 ++++++++----------- fs/jbd2/commit.c | 11 +++++------ fs/jbd2/journal.c | 6 ++---- fs/ntfs/file.c | 4 ++-- include/linux/buffer_head.h | 2 +- 5 files changed, 18 insertions(+), 24 deletions(-) -- 2.35.3
