Re: [PATCH] fs: use call_read_iter(file, &kiocb, &iter); for __kernel_{read|write}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/19/22 9:17 AM, Matthew Wilcox wrote:
> On Sat, Jun 18, 2022 at 08:19:11PM -0700, Li Chen wrote:
>> From: Li Chen <lchen@xxxxxxxxxxxxx>
>>
>> Just use these helper functions to replace f_op->{read,write}_iter()
> 
> ... why?  You've saved a massive two bytes of kernel source.
> What is the point of these functions?  I'd rather just get rid of them.

Agree, kill both of these helpers. They aren't very broadly used either.

-- 
Jens Axboe




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux