Re: [PATCH 06/10] keep iocb_flags() result cached in struct file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 07, 2022 at 11:31:39PM +0000, Al Viro wrote:
> * calculate at the time we set FMODE_OPENED (do_dentry_open() for normal
> opens, alloc_file() for pipe()/socket()/etc.)
> * update when handling F_SETFL
> * keep in a new field - file->f_i_flags; since that thing is needed only
> before the refcount reaches zero, we can put it into the same anon union
> where ->f_rcuhead and ->f_llist live - those are used only after refcount
> reaches zero.
> 
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> ---

Looks good to me (independent of whether that'll be called f_i_flag or f_iocb_flags),
Reviewed-by: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx>



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux