On Wed, Jun 01, 2022 at 03:20:28PM +0200, Alexey Gladkov wrote: > On Fri, Apr 22, 2022 at 01:44:50PM -0700, Linus Torvalds wrote: > > On Fri, Apr 22, 2022 at 5:53 AM Alexey Gladkov <legion@xxxxxxxxxx> wrote: > > > > > > Yes, Linus, these changes are not the refactoring you were talking > > > about, but I plan to try to do such a refactoring in the my next > > > patchset. > > > > Heh. Ok, I'm not saying these patches are pretty, and looking up the > > namespace thing is a bit subtle, but it's certainly prettier than the > > existing odd "create a new ctl_table entry because of field abuse". > > As I promised, here is one of the possible options for how to get rid of dynamic > memory allocation. > > We can slightly extend the API and thus be able to save data at the time the > file is opened. This will not only eliminate the need to allocate memory, but > also provide access to file struct and f_cred. > > I made an RFC because I'm not sure that I did the permissions check for > ipc_sysctl. I also did not change all the places where this API can be applied > to make the patch smaller. As in the case of /proc/sys/kernel/printk where > CAP_SYS_ADMIN is checked[1] for the current process at the time of write. Thanks for all this, can you also add respective selftests extensions for this on lib/test_sysctl.c and tools/testing/selftests/sysctl/sysctl.sh ? Luis
