On Thursday 02 April 2009 10:05:20 David Howells wrote: > Add a function to install a monitor on the page lock waitqueue for a particular > page, thus allowing the page being unlocked to be detected. > > This is used by CacheFiles to detect read completion on a page in the backing > filesystem so that it can then copy the data to the waiting netfs page. I prefer to nack this because it is exporting details of the page locking mechanism. unlock_page is very heavyweight in large part because of the memory barriers and cacheline required to check the waitqueue. I have patches to avoid all that if the page lock is not contended. What's wrong with using wait_on_page_locked, like everyone else does? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
