Re: [PATCH 21/24] buffer: Don't test folio error in block_read_full_folio()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
Subject: Re: [PATCH 21/24] buffer: Don't test folio error in block_read_full_folio()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 27 May 2022 23:05:19 -0700
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <20220527155036.524743-22-willy@infradead.org>

On Fri, May 27, 2022 at 04:50:33PM +0100, Matthew Wilcox (Oracle) wrote:
> We can cache this information in a local variable instead of communicating
> from one part of the function to another via folio flags.

Looks sensibel, but I'd invert the polarity and name this
buffers_uptodate to match the API call based on it.

References:
- [PATCH 00/24] Begin removing PageError
  - From: Matthew Wilcox (Oracle)
- [PATCH 21/24] buffer: Don't test folio error in block_read_full_folio()
  - From: Matthew Wilcox (Oracle)

Prev by Date: Re: [PATCH 20/24] btrfs: Use a folio in wait_dev_supers()
Next by Date: Re: [PATCH 22/24] squashfs: Return the actual error from squashfs_read_folio()
Previous by thread: [PATCH 21/24] buffer: Don't test folio error in block_read_full_folio()
Next by thread: [PATCH 09/24] nilfs2: Remove check for PageError
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux