Hey Linus,
/* Summary */
This contains two minor updates:
* An update to the idmapping documentation by Rodrigo making it easier to
understand that we first introduce several use-cases that fail without
idmapped mounts simply to explain how they can be handled with idmapped
mounts.
* When changing a mount's idmapping we now hold writers to make it more robust.
This is similar to turning a mount ro with the difference that in contrast to
turning a mount ro changing the idmapping can only ever be done once while a
mount can transition between ro and rw as much as it wants.
The vfs layer itself takes care to retrieve the idmapping of a mount once
ensuring that the idmapping used for vfs permission checking is identical to
the idmapping passed down to the filesystem. All filesystems with
FS_ALLOW_IDMAP raised take the same precautions as the vfs in code-paths that
are outside of direct control of the vfs such as ioctl()s.
However, holding writers makes this more robust and predictable for both the
kernel and userspace.
This is a minor user-visible change. But it is extremely unlikely to matter.
The caller must've created a detached mount via OPEN_TREE_CLONE and then
handed that O_PATH fd to another process or thread which then must've gotten
a writable fd for that mount and started creating files in there while the
caller is still changing mount properties. While not impossible it will be an
extremely rare corner-case and should in general be considered a bug in the
application. Consider making a mount MOUNT_ATTR_NOEXEC or MOUNT_ATTR_NODEV
while allowing someone else to perform lookups or exec'ing in parallel by
handing them a copy of the OPEN_TREE_CLONE fd or another fd beneath that
mount.
I've pinged all major users of idmapped mounts pointing out this change and
none of them have active writers on a mount while still changing mount
properties. It would've been strange if they did.
The rest and majority of the work will be coming through the overlayfs tree
this cycle. In addition to overlayfs this cycle should also see support for
idmapped mounts on erofs as I've acked a patch to this effect a little while
ago.
/* Testing */
All patches are based on v5.18-rc4 and have been sitting in linux-next.
Because of the patch changing how we set a mount's idmapping we had to remove
the now invalid test 781bb995a149e ("vfs/idmapped-mounts: remove invalid test")
from xfstests (see [1]). No build failures or warnings were observed and
fstests and selftests have seen no regressions.
Link: https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=781bb995a149e0dae074019e56477855587198cf [1]
/* Conflicts */
At the time of creating this PR no merge conflicts were reported from
linux-next and no merge conflicts showed up doing a test-merge with current
mainline.
The following changes since commit af2d861d4cd2a4da5137f795ee3509e6f944a25b:
Linux 5.18-rc4 (2022-04-24 14:51:22 -0700)
are available in the Git repository at:
git@xxxxxxxxxxxxxxxxxxx:pub/scm/linux/kernel/git/brauner/linux tags/fs.idmapped.v5.19
for you to fetch changes up to e1bbcd277a53e08d619ffeec56c5c9287f2bf42f:
fs: hold writers when changing mount's idmapping (2022-05-12 10:12:00 +0200)
Please consider pulling these changes from the signed fs.idmapped.v5.19 tag.
Thanks!
Christian
----------------------------------------------------------------
fs.idmapped.v5.19
----------------------------------------------------------------
Christian Brauner (1):
fs: hold writers when changing mount's idmapping
Rodrigo Campos (1):
docs: Add small intro to idmap examples
Documentation/filesystems/idmappings.rst | 5 +++++
fs/namespace.c | 5 +++--
2 files changed, 8 insertions(+), 2 deletions(-)
