Re: [PATCH -next] fuse: return the more nuanced writeback error on close()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2022/5/18 22:51, Al Viro 写道:
On Wed, May 18, 2022 at 10:57:29PM +0800, ChenXiaoSong wrote:

+	/* return more nuanced writeback errors */
  	if (err)
-		return err;
+		return filemap_check_wb_err(file->f_mapping, 0);
err = 0;

As an aside, what the hell is that err = 0 about?  Before or after
that patch, that is - "let's make err zero, in case it had somehow
magically changed ceased to be so since if (err) bugger_off just above"?

.

err = 0 is no longer needed after if (err), I will send v2 patch to remove the redundant code.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux