On 5/19/22 1:19 AM, Christoph Hellwig wrote: > On Wed, May 18, 2022 at 04:36:54PM -0700, Stefan Roesch wrote: >> This change uses the new iomap_page_create_gfp() function in the >> function __iomap_write_begin(). > > .. and this now loses the check if we actually need the creation, > see my previous comment. The new version avoids this problem by removing iomap_page_create_gfp() and adding a gfp flag to iomap_page_create().