Re: [PATCHv2 3/3] block: relax direct io memory alignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 19, 2022 at 10:27:04AM -0700, Eric Biggers wrote:
> On Thu, May 19, 2022 at 11:01:05AM -0600, Keith Busch wrote:
> > On Wed, May 18, 2022 at 10:56:04PM -0600, Keith Busch wrote:
> > > On Wed, May 18, 2022 at 08:27:31PM -0700, Eric Biggers wrote:
> > > > Note, there's also lots of code that assumes that bio_vec::bv_len is a multiple
> > > > of 512.  
> > > 
> > > Could you point me to some examples?
> > 
> > Just to answer my own question, blk-crypto and blk-merge appear to have these
> > 512 byte bv_len assumptions.
> 
> blk_bio_segment_split() and bio_advance_iter() are two more examples.

I agree about blk_bio_segment_split(), but bio_advance_iter() looks fine. That
just assumes the entire length is a multiple of 512, not any particular bvec.

Anyway, I accept your point that some existing code has this assumption, and
will address these before the next revision.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux