On Mon, May 16, 2022 at 12:19:25PM +0200, Fabio M. De Francesco wrote: > The use of kmap() is being deprecated in favor of kmap_local_page(). With > kmap_local_page(), the mapping is per thread, CPU local and not globally > visible. > > The usage of kmap_local_page() in fs/ufs is pre-thread, therefore replace > kmap() / kunmap() calls with kmap_local_page() / kunmap_local(). > > kunmap_local() requires the mapping address, so return that address from > ufs_get_page() to be used in ufs_put_page(). > > These changes are essentially ported from fs/ext2 and are largely based on > commit 782b76d7abdf ("fs/ext2: Replace kmap() with kmap_local_page()"). > > Suggested-by: Ira Weiny <ira.weiny@xxxxxxxxx> > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> Have you done more than compile-tested this? I'd like to know that it's been tested on a machine with HIGHMEM enabled (in a VM, presumably). UFS doesn't get a lot of testing, and it'd be annoying to put out a patch that breaks the kmap_local() rules.