The changes looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx> I did a little digging and the invalidatepage call first appeared in commit 90ce6b6a90f62578a141359ffe9261e65f2c5265 Author: Steve Lord <lord@xxxxxxx> Date: Mon Sep 2 12:36:59 2002 +0000 move page_buf_io.c to xfs_aops.c The old page_buf_io.c file seems to not have made it through to git, so this seems rather prehistoric.