Re: [PATCH] vfs: move fdput() to right place in ksys_sync_file_range()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Chengguang Xu <cgxu519@xxxxxxxxxxxx>
Subject: Re: [PATCH] vfs: move fdput() to right place in ksys_sync_file_range()
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Wed, 11 May 2022 16:51:34 +0100
Cc: viro@xxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20220511154503.28365-1-cgxu519@mykernel.net>

On Wed, May 11, 2022 at 11:45:03AM -0400, Chengguang Xu wrote:
> Move fdput() to right place in ksys_sync_file_range() to
> avoid fdput() after failed fdget().

Why?  fdput() is already conditional on FDPUT_FPUT so you're ...
optimising the failure case?

Follow-Ups:
- Re: [PATCH] vfs: move fdput() to right place in ksys_sync_file_range()
  - From: Eric Biggers

References:
- [PATCH] vfs: move fdput() to right place in ksys_sync_file_range()
  - From: Chengguang Xu

Prev by Date: Re: [PATCHSETS] v14 fsdax-rmap + v11 fsdax-reflink
Next by Date: Re: [PATCH v3 11/11] dm-zoned: ensure only power of 2 zone sizes are allowed
Previous by thread: [PATCH] vfs: move fdput() to right place in ksys_sync_file_range()
Next by thread: Re: [PATCH] vfs: move fdput() to right place in ksys_sync_file_range()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux