On 03/31/2009 11:04 AM, Andrew Morton wrote:
> On Wed, 18 Mar 2009 19:58:47 +0200 Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
>
>> implementation of the file_operations and inode_operations for
>> regular data files.
>>
>> Most file_operations are generic vfs implementations except:
>> - exofs_truncate will truncate the OSD object as well
>> - Generic file_fsync is not good for none_bd devices so open code it
>> - The default for .flush in Linux is todo nothing so call exofs_fsync
>> on the file.
>>
>>
>> ...
>>
>> +static int exofs_file_fsync(struct file *filp, struct dentry *dentry,
>> + int datasync)
>> +{
>> + int ret1, ret2;
>> + struct address_space *mapping = filp->f_mapping;
>> +
>> + ret1 = filemap_write_and_wait(mapping);
>> + ret2 = file_fsync(filp, dentry, datasync);
>> +
>> + return ret1 ? ret1 : ret2;
>> +}
>
> It might be better to abort if filemap_write_and_wait() failed. if the
> hardware is bad, these things can take a looooong time retrying and
> timing out. There's no point in doubling the delay.
>
>> ...
>>
>
OK I got confused by existing code, good point
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
