On Sun, May 08, 2022 at 09:32:45PM +0100, Matthew Wilcox (Oracle) wrote: > Saves a few calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> Acked-by: Theodore Ts'o <tytso@xxxxxxx> ... although I have one question: > - get_page(page); > + folio_get(folio); > __brelse(bh); > - try_to_free_buffers(page); > - unlock_page(page); > - put_page(page); > + try_to_free_buffers(&folio->page); The patches in this series seem to assume that the folio contains only a single page. Or at least, a *lot* more detailed auditing to make sure the right thing would happen if a page happens to be a member of a folio with more than a single page. Should we be adding some kind of WARN_ON to check this particular assumption? - Ted
