Re: [PATCH 00/26] Convert aops->releasepage to aops->release_folio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2022-05-08 at 21:32 +0100, Matthew Wilcox (Oracle) wrote:
> Convert all filesystems.  The last five patches are further cleanups
> that are enabled by this change.
> 
> Matthew Wilcox (Oracle) (26):
>   fs: Add aops->release_folio
>   iomap: Convert to release_folio
>   9p: Convert to release_folio
>   afs: Convert to release_folio
>   btrfs: Convert to release_folio
>   ceph: Convert to release_folio
>   cifs: Convert to release_folio
>   erofs: Convert to release_folio
>   ext4: Convert to release_folio
>   f2fs: Convert to release_folio
>   gfs2: Convert to release_folio
>   hfs: Convert to release_folio
>   hfsplus: Convert to release_folio
>   jfs: Convert to release_folio
>   nfs: Convert to release_folio
>   nilfs2: Remove comment about releasepage
>   ocfs2: Convert to release_folio
>   orangefs: Convert to release_folio
>   reiserfs: Convert to release_folio
>   ubifs: Convert to release_folio
>   fs: Remove last vestiges of releasepage
>   reiserfs: Convert release_buffer_page() to use a folio
>   jbd2: Convert jbd2_journal_try_to_free_buffers to take a folio
>   jbd2: Convert release_buffer_page() to use a folio
>   fs: Change try_to_free_buffers() to take a folio
>   fs: Convert drop_buffers() to use a folio
> 
>  .../filesystems/caching/netfs-api.rst         |  4 +-
>  Documentation/filesystems/locking.rst         | 14 ++---
>  Documentation/filesystems/vfs.rst             | 45 ++++++++--------
>  fs/9p/vfs_addr.c                              | 17 +++---
>  fs/afs/dir.c                                  |  7 ++-
>  fs/afs/file.c                                 | 11 ++--
>  fs/afs/internal.h                             |  2 +-
>  fs/btrfs/disk-io.c                            | 12 ++---
>  fs/btrfs/extent_io.c                          | 14 ++---
>  fs/btrfs/file.c                               |  2 +-
>  fs/btrfs/inode.c                              | 24 ++++-----
>  fs/buffer.c                                   | 54 +++++++++----------
>  fs/ceph/addr.c                                | 24 ++++-----
>  fs/cifs/file.c                                | 14 ++---
>  fs/erofs/super.c                              | 16 +++---
>  fs/ext4/inode.c                               | 20 +++----
>  fs/f2fs/checkpoint.c                          |  2 +-
>  fs/f2fs/compress.c                            |  2 +-
>  fs/f2fs/data.c                                | 32 +++++------
>  fs/f2fs/f2fs.h                                |  2 +-
>  fs/f2fs/node.c                                |  2 +-
>  fs/gfs2/aops.c                                | 44 +++++++--------
>  fs/gfs2/inode.h                               |  2 +-
>  fs/gfs2/meta_io.c                             |  4 +-
>  fs/hfs/inode.c                                | 23 ++++----
>  fs/hfsplus/inode.c                            | 23 ++++----
>  fs/iomap/buffered-io.c                        | 22 ++++----
>  fs/iomap/trace.h                              |  2 +-
>  fs/jbd2/commit.c                              | 14 ++---
>  fs/jbd2/transaction.c                         | 14 ++---
>  fs/jfs/jfs_metapage.c                         | 16 +++---
>  fs/mpage.c                                    |  2 +-
>  fs/nfs/file.c                                 | 22 ++++----
>  fs/nfs/fscache.h                              | 14 ++---
>  fs/nilfs2/inode.c                             |  1 -
>  fs/ocfs2/aops.c                               | 10 ++--
>  fs/orangefs/inode.c                           |  6 +--
>  fs/reiserfs/inode.c                           | 20 +++----
>  fs/reiserfs/journal.c                         | 14 ++---
>  fs/ubifs/file.c                               | 18 +++----
>  fs/xfs/xfs_aops.c                             |  2 +-
>  fs/zonefs/super.c                             |  2 +-
>  include/linux/buffer_head.h                   |  4 +-
>  include/linux/fs.h                            |  2 +-
>  include/linux/iomap.h                         |  2 +-
>  include/linux/jbd2.h                          |  2 +-
>  include/linux/page-flags.h                    |  2 +-
>  include/linux/pagemap.h                       |  4 --
>  mm/filemap.c                                  |  6 +--
>  mm/migrate.c                                  |  2 +-
>  mm/vmscan.c                                   |  2 +-
>  51 files changed, 309 insertions(+), 312 deletions(-)
> 

Looks like a mechanical change overall, and I like the conversion to
bool return instead of int. You can add this to the pile:

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux