On Sun, 1 May 2022 11:31:47 +0800 Tonghao Zhang wrote:
> static int __init test_sysctl_init(void)
> {
> + int i;
> +
nit: No empty line needed here.
> + struct {
> + int defined;
> + int wanted;
> + } match_int[] = {
> + {.defined = *(int *)SYSCTL_ZERO, .wanted = 0},
> + {.defined = *(int *)SYSCTL_ONE, .wanted = 1},
> + {.defined = *(int *)SYSCTL_TWO, .wanted = 2},
> + {.defined = *(int *)SYSCTL_THREE, .wanted = 3},
> + {.defined = *(int *)SYSCTL_FOUR, .wanted = 4},
> + {.defined = *(int *)SYSCTL_ONE_HUNDRED, .wanted = 100},
> + {.defined = *(int *)SYSCTL_TWO_HUNDRED, .wanted = 200},
> + {.defined = *(int *)SYSCTL_ONE_THOUSAND, .wanted = 1000},
> + {.defined = *(int *)SYSCTL_THREE_THOUSAND, .wanted = 3000},
> + {.defined = *(int *)SYSCTL_INT_MAX, .wanted = INT_MAX},
> + {.defined = *(int *)SYSCTL_MAXOLDUID, .wanted = 65535},
> + {.defined = *(int *)SYSCTL_NEG_ONE, .wanted = -1},
> + };
> +
> + for (i = 0; i < ARRAY_SIZE(match_int); i++)
> + if (match_int[i].defined != match_int[i].wanted)
> + match_int_ok = 0;
That's better, thank you!
