Re: [PATCH v5 3/3] fat: report creation time in statx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chung-Chiang Cheng <cccheng@xxxxxxxxxxxx> writes:

> creation time is no longer mixed with change time. Add an in-memory
> field for it, and report it in statx if supported.
>
> fat_truncate_crtime() is also removed. Because crtime comes from only
> the following two cases and won't be changed afterward.
>
> (1) vfat_lookup
> (2) vfat_create/vfat_mkdir -> vfat_add_entry -> vfat_build_slots
>
> They are all in {cdate:16, ctime:16, ctime_cs:8} format, which ensures
> crtime will be kept at the correct granularity (10 ms). The remaining
> timestamps may be copied from the vfs inode, so we need to truncate them
> to fit FAT's format. But crtime doesn't need to do that.

Hm, maybe right.  I'm not checking fully though, then we can remove
fat_truncate_time() in vfat_create/mkdir()?

(Actually msdos too though, the state of timestamps for msdos is
strange, mean on-disk and in-core timestamps are not sync. So not
including for now)

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux