On Sat, Mar 28, 2009 at 01:16:26AM +1100, Stephen Rothwell wrote: > > - switch (em->block_start) { > > - case EXTENT_MAP_LAST_BYTE: > > + if (em->block_start == EXTENT_MAP_LAST_BYTE) { > > I might be a good idea to put a comment there about why this isn't a > switch statement so that someone doesn't "clean up" this code in the > future. > nrrrgh. Remind me why we can't just add the libgcc helpers? Unless we plan on growing some more of these, surely we can just reduce it to a u32 for the switch... regards, Kyle -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html