on 2022/4/25 10:45, Matthew Wilcox wrote: > On Mon, Apr 25, 2022 at 11:09:38AM +0800, Yang Xu wrote: >> This has no functional change. Just create and export inode_sgid_strip >> api for the subsequent patch. This function is used to strip inode's >> S_ISGID mode when init a new inode. > > Why would you call this inode_sgid_strip() instead of > inode_strip_sgid()? Because I treated "inode sgid(inode's sgid)" as a whole. inode_strip_sgid sounds also ok, but now seems strip_inode_sgid seem more clear because we strip inode sgid depend on not only inode's condition but also depend on parent directory's condition. What do you think about this? ps: I can aceept the above several way, so if you insist, I can change it to inode_strip_sgid.
