Re: [PATCH] fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 15 Apr 2022 at 13:54, Bernd Schubert <bschubert@xxxxxxx> wrote:
>
> This is just a safety precaution to avoid checking flags
> on memory that was initialized on the user space side.
> libfuse zeroes struct fuse_init_out outarg, but this is not
> guranteed to be done in all implementations. Better is to
> act on flags and to only apply flags2 when FUSE_INIT_EXT
> is set.
>
> There is a risk with this change, though - it might break existing
> user space libraries, which are already using flags2 without
> setting FUSE_INIT_EXT.
>
> The corresponding libfuse patch is here
> https://github.com/libfuse/libfuse/pull/662
>
>
> Signed-off-by: Bernd Schubert <bschubert@xxxxxxx>

Agreed, this is a good change.  Applied.

Just one comment: please consider adding  "Fixes:" and "Cc:
<stable@....>" tags next time.   I added them now.

Thanks,
Miklos



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux