Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote:
> + if (IS_ENABLED(CONFIG_CACHEFILES_ONDEMAND) &&
> + !strcmp(args, "ondemand")) {
> + set_bit(CACHEFILES_ONDEMAND_MODE, &cache->flags);
> + } else if (*args) {
> + pr_err("'bind' command doesn't take an argument\n");
The error message isn't true if CONFIG_CACHEFILES_ONDEMAND=y. It would be
better to say "Invalid argument to the 'bind' command".
> -retry:
> /* If the caller asked us to seek for data before doing the read, then
> * we should do that now. If we find a gap, we fill it with zeros.
> */
> @@ -120,16 +119,6 @@ static int cachefiles_read(struct netfs_cache_resources *cres,
> if (read_hole == NETFS_READ_HOLE_FAIL)
> goto presubmission_error;
>
> - if (read_hole == NETFS_READ_HOLE_ONDEMAND) {
> - ret = cachefiles_ondemand_read(object, off, len);
> - if (ret)
> - goto presubmission_error;
> -
> - /* fail the read if no progress achieved */
> - read_hole = NETFS_READ_HOLE_FAIL;
> - goto retry;
> - }
> -
Unexplained deletion of newly added code.
David
