on 2022/4/19 22:02, Christian Brauner wrote: > On Tue, Apr 19, 2022 at 07:47:11PM +0800, Yang Xu wrote: >> Like other use ${fs}_init_acl and posix_acl_create filesystem, we don't >> need to assign NULL for acl and default_acl pointer because f2fs_acl_create >> will do this job. So remove it. >> >> Signed-off-by: Yang Xu<xuyang2018.jy@xxxxxxxxxxx> >> --- >> fs/f2fs/acl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c >> index eaa240b21f07..9ae2d2fec58b 100644 >> --- a/fs/f2fs/acl.c >> +++ b/fs/f2fs/acl.c >> @@ -412,7 +412,7 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode, >> int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage, >> struct page *dpage) >> { >> - struct posix_acl *default_acl = NULL, *acl = NULL; >> + struct posix_acl *default_acl, *acl; > > Hm, patches like this have nothing to do with the theme of this patch > series. They can go as completely independent patches to the relevant > fses. Imho, they don't belong with this series at all. Ok.