Re: [PATCH v2 3/3] fat: report creation time in statx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +
> > +     if (request_mask & STATX_BTIME) {
> > +             stat->result_mask |= STATX_BTIME;
> > +             stat->btime = MSDOS_I(inode)->i_crtime;
> > +     }
> > +
>
> [...]
>
> > -     if (sbi->options.isvfat)
> > +     if (sbi->options.isvfat) {
> >               fat_time_fat2unix(sbi, &inode->i_atime, 0, de->adate, 0);
> > -     else
> > +             fat_time_fat2unix(sbi, &MSDOS_I(inode)->i_crtime, de->ctime,
> > +                               de->cdate, de->ctime_cs);
> > +     } else {
> >               fat_truncate_atime(sbi, &inode->i_mtime, &inode->i_atime);
> > +             fat_truncate_crtime(sbi, &inode->i_mtime, &MSDOS_I(inode)->i_crtime);
> > +     }
>
> This looks strange. MSDOS doesn't have crtime, but set the fake time
> from mtime and returns to userspace. Why don't we disable STATX_BTIME
> for MSDOS?

Agree. It's not necessary to report in statx.

Thanks.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux