On Tue, Mar 29, 2022 at 10:49 AM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > Jan, > > Following the discussion on direct reclaim of fsnotify marks [2], > this patch set includes your suggested fixes to core code along with > implementation of fanotify evictable marks (rebrand of volatile marks). > > The LTP test I wrote [3] reproduces that deadlock within seconds on my > small test VM if the FSNOTIFY_GROUP_NOFS flag is removed from fanotify. > > To be more exact, depending on the value of vfs_cache_pressure set by > the test, either a deadlock or lockdep warning (or both) are reproduced. > I chose a high value of 500, which usually reproduces only the lockdep > warning, but worked better and faster on several systems I tested on. > > Thanks, > Amir. > > Changes since v1 [1]: > - Fixes for direct reclaim deadlock > - Add ioctl for direct reclaim test > - Rebrand as FAN_MARK_EVICTABLE > - Remove FAN_MARK_CREATE and allow clearing FAN_MARK_EVICTABLE > - Replace connector proxy_iref with HAS_IREF flag > - Take iref in fsnotify_reclac_mark() rather than on add mark to list > - Remove fsnotify_add_mark() allow_dups/flags argument > - Remove pr_debug() prints > > [1] https://lore.kernel.org/r/20220307155741.1352405-1-amir73il@xxxxxxxxx/ > [2] https://lore.kernel.org/r/20220321112310.vpr7oxro2xkz5llh@xxxxxxxxxx/ > [3] https://github.com/amir73il/ltp/commits/fan_evictable And here is a first man-page draft: https://github.com/amir73il/man-pages/commits/fan_evictable Thanks, Amir.
