On Fri, Apr 08, 2022 at 10:36:40AM +0800, JeffleXu wrote: > > > On 4/7/22 10:10 PM, Vivek Goyal wrote: > > On Sat, Apr 02, 2022 at 06:32:50PM +0800, Jeffle Xu wrote: > >> Move dmap free worker kicker inside the critical region, so that extra > >> spinlock lock/unlock could be avoided. > >> > >> Suggested-by: Liu Jiang <gerry@xxxxxxxxxxxxxxxxx> > >> Signed-off-by: Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> > > > > Looks good to me. Have you done any testing to make sure nothing is > > broken. > > xfstests -g quick shows no regression. The tested virtiofs is mounted > with "dax=always". I think xfstests might not trigger reclaim. You probably will have to run something like blogbench with a small dax window like 1G so that heavy reclaim happens. For fun, I sometimes used to run it with a window of just say 16 dax ranges so that reclaim was so heavy that if there was a bug, it will show up. Thanks Vivek
