On Thu, Mar 03, 2022 at 04:23:26PM -0800, Luis Chamberlain wrote: > On Fri, Mar 04, 2022 at 12:44:48AM +0100, Daniel Borkmann wrote: > > On 3/2/22 9:39 PM, Luis Chamberlain wrote: > > > On Wed, Mar 02, 2022 at 10:04:12AM +0800, Yan Zhu wrote: > > > > We're moving sysctls out of kernel/sysctl.c as its a mess. We > > > > already moved all filesystem sysctls out. And with time the goal is > > > > to move all sysctls out to their own susbsystem/actual user. > > > > > > > > kernel/sysctl.c has grown to an insane mess and its easy to run > > > > into conflicts with it. The effort to move them out is part of this. > > > > > > > > Signed-off-by: Yan Zhu <zhuyan34@xxxxxxxxxx> > > > > > > Daniel, let me know if this makes more sense now, and if so I can > > > offer take it through sysctl-next to avoid conflicts more sysctl knobs > > > get moved out from kernel/sysctl.c. > > > > If this is a whole ongoing effort rather than drive-by patch, > > It is ongoing effort, but it will take many releases before we tidy > this whole thing up. > > > then it's > > fine with me. > > OK great. Thanks for understanding the mess. > > > Btw, the patch itself should also drop the linux/bpf.h > > include from kernel/sysctl.c since nothing else is using it after the > > patch. > > I'll let Yan deal with that. Yan, feel free to resubmit based on sysctl-next [0]. [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next Luis
