On Thu, Mar 31, 2022 at 05:28:22PM +0800, Yang Xu wrote: > Since stipping S_SIGID should check S_IXGRP, so umask it to check whether > works well. > > Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx> > --- (Sidenote: I really need to rename the test binary to something other than idmapped-mounts.c as this tests a lot of generic vfs stuff that has nothing to do with them.) Tested-by: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx> Reviewed-by: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx> > If we enable acl on parent directory, then umask is useless, maybe we > also add setfacl on parent directory because we may change the order > about strip S_ISGID and posix_acl setup. Any idea? If acls figure into this then this should probably be a new test or subtest.
