On Wed, Mar 30, 2022 at 07:52:11AM -0700, Christoph Hellwig wrote: > On Wed, Mar 30, 2022 at 03:49:21PM +0100, Matthew Wilcox (Oracle) wrote: > > Remove the unnecessary variable 'len' and fix a comment to refer to > > the folio instead of the page. > > I'd rather keep the len name instead of count, but either way this looks > ok: Heh, that was the way I did it first. But block_is_partially_uptodate() uses 'count', include/linux/fs.h calls it 'count' and one of the two callers in mm/filemap.c calls it 'count', so I thought it was probably best to not call it len.