> + > +/* > + * Like lookup_positive_unlocked() but takes a mount's idmapping into account. > + */ Can you add a real kerneldoc comment here instead of referring to another function that will hopefully be removed rather sooner than later? > +struct dentry *lookup_one_unlocked(struct user_namespace *, const char *, struct dentry *, int); > +struct dentry *lookup_one_positive_unlocked(struct user_namespace *, const char *, struct dentry *, int); Please spellt out the parameter names and avoid the overy long lines. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
