On Tue, Mar 29, 2022 at 12:45:16PM +0200, Christian Brauner wrote: > On Mon, Mar 28, 2022 at 05:56:27PM +0800, Yang Xu wrote: > > inode_sgid_strip() function is used to strip S_ISGID mode > > when creat/open/mknod file. > > > > Suggested-by: Dave Chinner <david@xxxxxxxxxxxxx> > > Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx> > > --- > > I would've personally gone for returning umode_t but this work for me > too. Agreed, that's a much nicer API for this function - it makes it clear that it can modifying the mode that is passed in. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
