jianchunfu <jianchunfu@xxxxxxxxxxxxxxxxxxxx> writes: > I'm not sure why there are so many missing checks of the malloc function, > is it because the memory allocated is only a few bytes > so no checks are needed? > > Signed-off-by: jianchunfu <jianchunfu@xxxxxxxxxxxxxxxxxxxx> Hi jianchunfu, Thanks for the patch. Beyond what Eric said, the patch prefix should be just "unicode:". When in doubt you can see the previous patches to the subsystem in the git log. Also, I think these are not really stack overflows, but a bad memory access if malloc fails. What do you think of something like unicode: Handle memory allocation failures in mkutf8data or something like that. Thanks, -- Gabriel Krisman Bertazi