Re: [PATCH] fs/dcache: use write lock in the fallback instead of read lock

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Fri, Mar 25, 2022 at 05:48:43PM +0100, Niels Dossche wrote:
> >> -	WARN(down_read_trylock(&sb->s_umount), "s_umount should've been locked");
> >> +	WARN(down_write_trylock(&sb->s_umount), "s_umount should've been locked");
> > 
> > This really should be a lockdep_assert_held_write() instead.
> 
> That's probably a bit nicer indeed.
> I can write up a patch that does a lockdep_assert_held_write() if you want.

I would much prefer that.