Hi Stephen, Thank you for the patch! Yet something to improve: [auto build test ERROR on 5191290407668028179f2544a11ae9b57f0bcf07] url: https://github.com/0day-ci/linux/commits/Stephen-Kitt/idr-Remove-unused-ida_simple_-get-remove/20220323-062521 base: 5191290407668028179f2544a11ae9b57f0bcf07 config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220323/202203230845.E0LTB8eP-lkp@xxxxxxxxx/config) compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/13945a32161b59a82eca06de385ea0f38b88439e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stephen-Kitt/idr-Remove-unused-ida_simple_-get-remove/20220323-062521 git checkout 13945a32161b59a82eca06de385ea0f38b88439e # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): fs/eventfd.c: In function 'eventfd_free_ctx': >> fs/eventfd.c:92:3: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] 92 | ida_simple_remove(&eventfd_ida, ctx->id); | ^~~~~~~~~~~~~~~~~ fs/eventfd.c: In function 'do_eventfd': >> fs/eventfd.c:426:12: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration] 426 | ctx->id = ida_simple_get(&eventfd_ida, 0, 0, GFP_KERNEL); | ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- fs/proc/generic.c: In function 'proc_alloc_inum': >> fs/proc/generic.c:206:6: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration] 206 | i = ida_simple_get(&proc_inum_ida, 0, UINT_MAX - PROC_DYNAMIC_FIRST + 1, | ^~~~~~~~~~~~~~ fs/proc/generic.c: In function 'proc_free_inum': >> fs/proc/generic.c:217:2: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] 217 | ida_simple_remove(&proc_inum_ida, inum - PROC_DYNAMIC_FIRST); | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- block/blk-core.c: In function 'blk_alloc_queue': >> block/blk-core.c:456:10: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration] 456 | q->id = ida_simple_get(&blk_queue_ida, 0, 0, GFP_KERNEL); | ^~~~~~~~~~~~~~ >> block/blk-core.c:506:2: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] 506 | ida_simple_remove(&blk_queue_ida, q->id); | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- block/blk-sysfs.c: In function 'blk_release_queue': >> block/blk-sysfs.c:796:2: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] 796 | ida_simple_remove(&blk_queue_ida, q->id); | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- drivers/base/swnode.c: In function 'software_node_release': >> drivers/base/swnode.c:750:3: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] 750 | ida_simple_remove(&swnode->parent->child_ids, swnode->id); | ^~~~~~~~~~~~~~~~~ drivers/base/swnode.c: In function 'swnode_register': >> drivers/base/swnode.c:779:8: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration] 779 | ret = ida_simple_get(parent ? &parent->child_ids : &swnode_root_ids, | ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- drivers/input/input.c: In function 'input_get_new_minor': >> drivers/input/input.c:2577:15: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration] 2577 | int minor = ida_simple_get(&input_ida, | ^~~~~~~~~~~~~~ drivers/input/input.c: In function 'input_free_minor': >> drivers/input/input.c:2600:2: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] 2600 | ida_simple_remove(&input_ida, minor); | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- drivers/ptp/ptp_clock.c: In function 'ptp_clock_release': >> drivers/ptp/ptp_clock.c:177:2: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] 177 | ida_simple_remove(&ptp_clocks_map, ptp->index); | ^~~~~~~~~~~~~~~~~ drivers/ptp/ptp_clock.c: In function 'ptp_clock_register': >> drivers/ptp/ptp_clock.c:212:10: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration] 212 | index = ida_simple_get(&ptp_clocks_map, 0, MINORMASK + 1, GFP_KERNEL); | ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- net/core/xdp.c: In function '__xdp_mem_allocator_rcu_free': >> net/core/xdp.c:76:2: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] 76 | ida_simple_remove(&mem_id_pool, xa->mem.id); | ^~~~~~~~~~~~~~~~~ net/core/xdp.c: In function '__mem_id_cyclic_get': >> net/core/xdp.c:241:7: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration] 241 | id = ida_simple_get(&mem_id_pool, mem_id_next, MEM_ID_MAX, gfp); | ^~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/ida_simple_remove +92 fs/eventfd.c e1ad7468c77ddb Davide Libenzi 2007-05-10 88 562787a5c32ccd Davide Libenzi 2009-09-22 89 static void eventfd_free_ctx(struct eventfd_ctx *ctx) 562787a5c32ccd Davide Libenzi 2009-09-22 90 { b556db17b0e7c4 Masatake YAMATO 2019-05-14 91 if (ctx->id >= 0) b556db17b0e7c4 Masatake YAMATO 2019-05-14 @92 ida_simple_remove(&eventfd_ida, ctx->id); 562787a5c32ccd Davide Libenzi 2009-09-22 93 kfree(ctx); 562787a5c32ccd Davide Libenzi 2009-09-22 94 } 562787a5c32ccd Davide Libenzi 2009-09-22 95 -- 0-DAY CI Kernel Test Service https://01.org/lkp
