On Mon, Mar 21, 2022 at 02:14:03PM +0000, David Howells wrote: > Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > > Why do you have a separate rwlock when the xarray already has its own > > spinlock? This is usually a really bad idea. > > Jeffle wants to hold a lock across the CACHEFILES_DEAD check and the xarray > access. > > However, he tells xarray to do a GFP_KERNEL alloc whilst holding the rwlock:-/ Yeah, sorry, there are trivial mistakes due to sleep in atomic contexts (sorry that I didn't catch them earlier..) Thanks, Gao Xiang > > David > -- > Linux-cachefs mailing list > Linux-cachefs@xxxxxxxxxx > https://listman.redhat.com/mailman/listinfo/linux-cachefs
