On 2022/03/13 02:49, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > TBH, I'd rather avoid breeding chain includes; sure, mutex.h and wait.h > are extremely common anyway. Oh, well.... In my usual coding style, I expect I can include any header and it will bring its whole dependency chain (which should be as small as possible, but not smaller). This seems cleaner to me, because .c files need to have no insight what a .h file needs (even if the dependencies are "extremely common"). If the kernel coding style does not consider this useful, we can of course easily drop that patch.