> On Mar 4, 2022, at 3:06 PM, Steve French <smfrench@xxxxxxxxx> wrote: > > On Tue, Feb 1, 2022 at 10:51 PM Chuck Lever III <chuck.lever@xxxxxxxxxx> wrote: >> >>> On Jan 31, 2022, at 4:06 PM, David Howells <dhowells@xxxxxxxxxx> wrote: >>> >>> I've been working on a library (in fs/netfs/) to provide network filesystem >>> support services, with help particularly from Jeff Layton. The idea is to >>> move the common features of the VM interface, including request splitting, >>> operation retrying, local caching, content encryption, bounce buffering and >>> compression into one place so that various filesystems can share it. >> >> IIUC this suite of functions is beneficial mainly to clients, >> is that correct? I'd like to be clear about that, this is not >> an objection to the topic. >> >> I'm interested in discussing how folios might work for the >> NFS _server_, perhaps as a separate or adjunct conversation. > > That is an interesting point. Would like to also discuss whether it > could help ksmbd, Agreed that ksmbd might also benefit. Of primary interest is how read and write operations move their payloads from the network transports directly to the page cache. For the most efficient operation, the transport layer would need to set up a receive buffer using page cache pages instead of what is currently done: receive buffers are constructed from anonymous pages and then these pages replace the file's page cache pages. RDMA transports make this straightforward, at least from the transport layer's perspective. > and would like to continue discussion of netfs improvements - especially am > interested in how we can improve throttling when network (or server) > is congested > (or as network adapters are added/removed and additional bandwidth is > available). As I understand it, the protocols themselves have flow control built in. At least SMB Direct and NFS/RDMA do, and NFSv4 sessions provides a similar mechanism for transports that don't have a native flow control mechanism. I'm not sufficiently familiar with SMB to know how flow control works there. However, each of these mechanisms all have their own specific rules. I'm not sure if there's much that can be extracted into a common library, but can you be more specific about what is needed? -- Chuck Lever
