The assignment of ch after subtracting ('a' - 'A') is redundant and can be removed. Fix this by replacing the -= operator with just - to remove the assignment. Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> --- fs/affs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/affs/namei.c b/fs/affs/namei.c index bcab18956b4f..a1270deba908 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c @@ -19,7 +19,7 @@ typedef int (*toupper_t)(int); static int affs_toupper(int ch) { - return ch >= 'a' && ch <= 'z' ? ch -= ('a' - 'A') : ch; + return ch >= 'a' && ch <= 'z' ? ch - ('a' - 'A') : ch; } /* International toupper() for DOS\3 ("international") */ -- 2.35.1