On Tue, Mar 01, 2022 at 08:42:15PM +0200, Amir Goldstein wrote: > Miklos, > > Following your feedback on v2 [1], I moved the iostats to per-sb. > > Thanks, > Amir. > > [1] https://lore.kernel.org/linux-unionfs/20220228113910.1727819-1-amir73il@xxxxxxxxx/ > > Changes since v2: > - Change from per-mount to per-sb io stats (szeredi) > - Avoid percpu loop when reading mountstats (dchinner) > > Changes since v1: > - Opt-in for per-mount io stats for overlayfs and fuse Why make it optional only for specific filesystem types? Shouldn't every superblock capture these stats and export them in exactly the same place? Making it properly generic greatly simplifies the implementation, too... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx