Let's bring inode_operations in sync for bad_inode_ops. Some of the reasons for doing this are listed here [1]. But mostly it is just for completeness sake. [1]: https://lore.kernel.org/lkml/1473708559-12714-2-git-send-email-mszeredi@xxxxxxxxxx/ Signed-off-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx> --- v1 -> v2 1. Rebased. 2. Removed end of line whitespace fixes as it could quickly give conflicts while applying. fs/bad_inode.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/fs/bad_inode.c b/fs/bad_inode.c index 12b8fdcc445b..cefd4ed8d5b2 100644 --- a/fs/bad_inode.c +++ b/fs/bad_inode.c @@ -160,6 +160,17 @@ static int bad_inode_set_acl(struct user_namespace *mnt_userns, return -EIO; } +static int bad_inode_fileattr_set(struct user_namespace *mnt_userns, + struct dentry *dentry, struct fileattr *fa) +{ + return -EIO; +} + +static int bad_inode_fileattr_get(struct dentry *dentry, struct fileattr *fa) +{ + return -EIO; +} + static const struct inode_operations bad_inode_ops = { .create = bad_inode_create, @@ -183,6 +194,8 @@ static const struct inode_operations bad_inode_ops = .atomic_open = bad_inode_atomic_open, .tmpfile = bad_inode_tmpfile, .set_acl = bad_inode_set_acl, + .fileattr_set = bad_inode_fileattr_set, + .fileattr_get = bad_inode_fileattr_get, }; -- 2.25.1