I don't think that gfp flags are a great fit here. We only want to pass in a nowait flag and this does not map nicely to a gfp flag. Instead of passing in a flag parameter we can also pass in a bool parameter, however that has its limitations as it can't be extended in the future. On 2/14/22 11:02 AM, Matthew Wilcox wrote: > On Mon, Feb 14, 2022 at 09:43:50AM -0800, Stefan Roesch wrote: >> This adds a flags parameter to the __begin_write_begin_int() function. >> This allows to pass flags down the stack. > > In general, I am not in favour of more AOP_FLAG uses. I'd prefer to > remove the two that we do have (reiserfs is the only user of > AOP_FLAG_CONT_EXPAND and AOP_FLAG_NOFS can usually be replaced by > passing in gfp_t flags).
