On Thu, Feb 26, 2009 at 10:20:18AM +0100, Peter Zijlstra wrote:
> On Wed, 2009-02-25 at 10:36 +0100, Nick Piggin wrote:
> > + if (!page_mkwrite)
> > + wait_on_page_locked(dirty_page);
> > set_page_dirty_balance(dirty_page, page_mkwrite);
> > put_page(dirty_page);
> > + if (page_mkwrite) {
> > + unlock_page(old_page);
> > + page_cache_release(old_page);
> > + }
>
> We're calling into the whole balance_dirty_pages() writeout path with a
> page locked.. is that sensible?
Yeah, probably should move the balance out of there.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
