On Sun, Feb 13, 2022 at 11:02:06PM -0800, John Hubbard wrote:
> I was just reading through this in case my pin_user_pages() changes
> had any overlap (I think not), and noticed a build issue, below.
I agree; unlikely to have any conflicts with mm things in this patchset.
This should be purely fs. There's obviously more conversions coming in
the aops api, but I thought this was a good start.
Still need to do writepage, readpage, write_begin, write_end,
releasepage, freepage, migratepage, isolate_page, putback_page,
is_dirty_writeback, and _maybe_ error_remove_page. sendpage is
also something I'll need to look at.
> > }
> > -static inline int ceph_fscache_set_page_dirty(struct page *page)
> > +static inline int ceph_fscache_dirty_folio(struct address_space *mapping,
> > + struct folio *folio)
> > {
> > - return __set_page_dirty_nobuffers(page);
> > + return filemap_dirty_folio(folio);
>
> I believe that should be:
>
> return filemap_dirty_folio(mapping, folio);
Indeed it should; thanks, fixed. allmodconfig doesn't test all code
paths ;-)
