Re: [PATCH] Fix read-only superblock in case of subvol RO remount

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19:27 10/02, Matthew Wilcox wrote:
> On Thu, Feb 10, 2022 at 10:51:42AM -0600, Goldwyn Rodrigues wrote:
> >  	WRITE_ONCE(sb->s_flags, ((sb->s_flags & ~fc->sb_flags_mask) |
> > -				 (fc->sb_flags & fc->sb_flags_mask)));
> > +				 (sb->s_flags & fc->sb_flags_mask)));
> > +
> 
> what?
> 
> (a & ~b) | (a & b) == a, no?

Yup! I am re-enrolling into middle school to learn bit-arithmetic.

Apparently, I don't need this change at all and can be done in btrfs
code by changing the flags parameter.

Will post a patch to btrfs ML with the updated patch.

-- 
Goldwyn



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux