Hi "Eric, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc2 next-20220131] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Eric-W-Biederman/coredump-Move-definition-of-struct-coredump_params-into-coredump-h/20220201-034653 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 26291c54e111ff6ba87a164d85d4a4e134b7315c config: m68k-m5208evb_defconfig (https://download.01.org/0day-ci/archive/20220201/202202010957.uywEsvch-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/51661b08028418cf7e46f97d7e7dbee927cd61e0 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Eric-W-Biederman/coredump-Move-definition-of-struct-coredump_params-into-coredump-h/20220201-034653 git checkout 51661b08028418cf7e46f97d7e7dbee927cd61e0 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:29, from fs/binfmt_flat.c:21: fs/binfmt_flat.c: In function 'flat_core_dump': >> fs/binfmt_flat.c:118:50: error: invalid use of undefined type 'struct coredump_params' 118 | current->comm, current->pid, cprm->siginfo->si_signo); | ^~ include/linux/printk.h:418:33: note: in definition of macro 'printk_index_wrap' 418 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/printk.h:499:9: note: in expansion of macro 'printk' 499 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~ fs/binfmt_flat.c:117:9: note: in expansion of macro 'pr_warn' 117 | pr_warn("Process %s:%d received signr %d and should have core dumped\n", | ^~~~~~~ vim +118 fs/binfmt_flat.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 108 ^1da177e4c3f41 Linus Torvalds 2005-04-16 109 /****************************************************************************/ ^1da177e4c3f41 Linus Torvalds 2005-04-16 110 /* ^1da177e4c3f41 Linus Torvalds 2005-04-16 111 * Routine writes a core dump image in the current directory. ^1da177e4c3f41 Linus Torvalds 2005-04-16 112 * Currently only a stub-function. ^1da177e4c3f41 Linus Torvalds 2005-04-16 113 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 114 f6151dfea21496 Masami Hiramatsu 2009-12-17 115 static int flat_core_dump(struct coredump_params *cprm) ^1da177e4c3f41 Linus Torvalds 2005-04-16 116 { 4adbb6ac4b807e Nicolas Pitre 2016-07-24 117 pr_warn("Process %s:%d received signr %d and should have core dumped\n", 13c3f50c914e6a Nicolas Pitre 2016-07-24 @118 current->comm, current->pid, cprm->siginfo->si_signo); 13c3f50c914e6a Nicolas Pitre 2016-07-24 119 return 1; ^1da177e4c3f41 Linus Torvalds 2005-04-16 120 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 121 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx