On Mon, Jan 31, 2022 at 12:44:53PM -0600, Eric W. Biederman wrote: > > Matthew Wilcox has reported that a missing mmap_lock in file_files_note, > which could cause trouble. > > Refactor the code and clean it up so that the vma snapshot makes > it to fill_files_note, and then use the vma snapshot in fill_files_note. > > Folks please review this as this looks correct to me but I haven't done > anything beyond compile testing this yet. > > Eric W. Biederman (5): > coredump: Move definition of struct coredump_params into coredump.h > coredump: Snapshot the vmas in do_coredump > coredump: Remove the WARN_ON in dump_vma_snapshot > coredump/elf: Pass coredump_params into fill_note_info > coredump: Use the vma snapshot in fill_files_note > > fs/binfmt_elf.c | 61 ++++++++++++++++++++++-------------------------- > fs/binfmt_elf_fdpic.c | 18 +++++--------- > fs/coredump.c | 55 +++++++++++++++++++++++++++++-------------- > include/linux/binfmts.h | 13 +---------- > include/linux/coredump.h | 20 ++++++++++++---- > 5 files changed, 88 insertions(+), 79 deletions(-) > > > Eric This looks like a good clean-up to me. For the series: Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> -- Kees Cook
