On Tue, Jan 25, 2022 at 06:18:09PM -0800, Darrick J. Wong wrote:
> Hi all,
>
> While auditing the VFS code, I noticed that while ->sync_fs is allowed
> to return error codes to reflect some sort of internal filesystem error,
> none of the callers actually check the return value. Back when this
> callout was introduced for sync_filesystem in 2.5 this didn't matter
(Also, it looks like that most(/none?) of the filesystems that
implemented ->sync_fs around 2.5/2.6 (ext3, jfs, jffs2, reiserfs etc.)
actually did return an error?
In fact, 5.8 seems to be the first kernel to report other errors than
-EBADF since commit 735e4ae5ba28 ("vfs: track per-sb writeback errors
and report them to syncfs"?)
