Re: [RFC PATCH 1/7] cifs: Transition from ->readpages() to ->readahead()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [RFC PATCH 1/7] cifs: Transition from ->readpages() to ->readahead()
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Tue, 25 Jan 2022 14:20:21 +0000
Cc: smfrench@xxxxxxxxx, nspmangalore@xxxxxxxxx, Jeff Layton <jlayton@xxxxxxxxxx>, linux-cifs@xxxxxxxxxxxxxxx, linux-cachefs@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <164311906472.2806745.605202239282432844.stgit@warthog.procyon.org.uk>

On Tue, Jan 25, 2022 at 01:57:44PM +0000, David Howells wrote:
> +	while (readahead_count(ractl) - ractl->_batch_count) {

You do understand that prefixing a structure member with an '_' means
"Don't use this", right?  If I could get the compiler to prevent you, I
would.

References:
- [RFC][RFC PATCH 0/7] cifs: In-progress conversion to use iov_iters and netfslib
  - From: David Howells
- [RFC PATCH 1/7] cifs: Transition from ->readpages() to ->readahead()
  - From: David Howells

Prev by Date: Re: [PATCH] proc: use kmalloc instead of __get_free_page() to alloc path buffer
Next by Date: Re: [PATCH REPOST] fs/namespace: Boost the mount_lock.lock owner instead of spinning on PREEMPT_RT.
Previous by thread: [RFC PATCH 1/7] cifs: Transition from ->readpages() to ->readahead()
Next by thread: Re: [RFC PATCH 1/7] cifs: Transition from ->readpages() to ->readahead()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux