On Tue, Jan 18, 2022 at 8:56 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> Note that a lot of the IS_ENALBED() checks could be turned from cpp
> statements into normal ifs, but this change is intended to be fairly
> mechanic, so that should be cleaned up later.
Yeah, that patch looks uglier than what I would have hoped for, but a
number of the conversions really look like they then would get a lot
cleaner if the IS_ENABLED() was part of the code flow, rather than
have those ugly (and now arguably even uglier) #ifdef's inside code.
And I think the mechanical conversion is the right thing to do, with
any cleanup being separate.
I'll look at this again when I have all my pulls done.
Linus
