On Sun, February 15, 2009 3:03 pm, Evgeniy Polyakov wrote: > Hi Adrian. Hi > > That's all for now. Overall there is a fair numebr of leaks > because of the missed freeing in the error path and lots of duplicated > code because of the multiple error exit points. Also you frequently do > not check the return value of the functions which may fail. > > -- > Evgeniy Polyakov > Thanks for the comments. Very useful. I ported this over from some truly abysmal code I'd written years ago and clearly didn't do a good enough job :) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html